Modernize bash completion setup #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| endif() | ||
| install(DIRECTORY bash_completion.d/ DESTINATION ${BASH_COMPLETION_INST_DIR}) | ||
| install(FILES bash_completion.d/ldc DESTINATION ${BASH_COMPLETION_COMPLETIONSDIR} RENAME ldc2) |
There was a problem hiding this comment.
I'd just rename the source file.
There was a problem hiding this comment.
That would work as well, yes.
|
Could you just rename the source file? I'd like to keep the installation process as simple as possible. Ready to merge otherwise. |
The completion is installed alongside the command anyway.
Will be provided in bash completion >= 2.2.
redstar
added a commit
that referenced
this pull request
Feb 21, 2015
Modernize bash completion setup
|
Thanks! |
|
Hm. There is no package bash-completion distributed with cmake. Now all builds issue a cmake warning. |
|
I think it is installed on the system as part of newer bash-completion packages. But yeah, I missed that the package is not looked up in quiet mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.