Should gh.nvim config.prefer_https_remote use gh config?

[dlvhdr]

The gh config already stores the user preference for https/ssh.
Do you think you should respect that as well? as all the other actions use gh under the hood I'm assuming.

[ldelossa]

Aha!

🖭  gh config list
git_protocol=ssh
editor=
prompt=enabled
pager=
http_unix_socket=
browser=

That would be pretty cool, and probably the right thing to do, so you're thinking, on gh.nvim startup, do something like:

🖭  gh config get git_protocol
https

and then automatically set the git remote accordingly?

[dlvhdr]

Yes I think thats the approach

[ldelossa]

Would you want to take on that PR? Seems relatively straight forward.

[dlvhdr]

Yeah I can do that

[ldelossa]

Cool, we may want an "auto" flag in the "prefer_https_remotes" config value, where we dynamically look it up. This then still allows the user to force "ssh" or "https" if they want to. Maybe its useful?

[dlvhdr]

My intuition is that a user wouldn't need to define a different protocol for gh.nvim that is different than gh.
I would add it in the future if there's an interest but I could be wrong here

[ldelossa]

@David-Kunz in issue #15 you had to flip the "prefer_https_remote" flag in your private repo.

In this issue we are trying to determine if we looked at the "gh config list" command and set the remote type with the setting in there, would it have set the correct remote protocol for you?

Could you run that command in your private repo where you're using the "prefer_https_remote" flag and tell us the value of the "git_protocol" config.

[David-Kunz]

Hi @ldelossa,

When I execute gh config list, the value is gh_protocol=https.

Best regards,
David

[ldelossa]

Cool, thanks @David-Kunz.

a little unscientific @dlvhdr but seems like on all our systems the gh cli matches the git protocol that works. Just wanted to make sure.

[ldelossa]

Closed! Thanks again @dlvhdr

[ldelossa]

Thank occurred just now:

~/git/vim/litee-gh-testing remotes/litee-gh_ldelossa/litee-gh-testing/branch-1
🖭  gh config list
git_protocol=ssh
editor=
prompt=enabled
pager=
http_unix_socket=
browser=

~/git/vim/litee-gh-testing remotes/litee-gh_ldelossa/litee-gh-testing/branch-1
🖭  gh config get git_protocol
https

Weird lol. I manually set it to get it to work again.

~/git/vim/litee-gh-testing main
🖭  gh config set git_protocol ssh

~/git/vim/litee-gh-testing main
🖭  gh config get git_protocol    
ssh