Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdheigh=0 flickering on neovim/neovim#20644 #74

Open
arsham opened this issue Oct 15, 2022 · 6 comments
Open

cmdheigh=0 flickering on neovim/neovim#20644 #74

arsham opened this issue Oct 15, 2022 · 6 comments

Comments

@arsham
Copy link

arsham commented Oct 15, 2022

On startup the statusbar flickers. See for more information.

Steps to reproduce

Compile neovim with this. Start neovim.

@ldelossa
Copy link
Owner

Gh.nvim utilizes vim.api.nvim_echo() extensively to write info to the status line. I havent played with this setting much, but I do remember that the api didnt play well with cmdheight set to zero. Could this be related to the issue?

@arsham
Copy link
Author

arsham commented Oct 15, 2022

Good point there. Let me check if that API causes the flickering.

@arsham
Copy link
Author

arsham commented Oct 15, 2022

Yep, that's it!

@ldelossa
Copy link
Owner

ldelossa commented Oct 15, 2022

Yeah, im not sure how the Neovim core team advises to handle this. From my point of view that new cmdheight just kinda breaks the echo api at times.

I havent gotten around to removing the echo api usage, one because i personally like and and two because im waiting to see if neovim core fixes little issues like this.

@arsham
Copy link
Author

arsham commented Oct 15, 2022

Fair enough.
One thing though, would there an autocmd firing at some point that would echo an empty string? I'm saying this because when this plugin loads, there are no visible characters echoed. I did the following and the end result was the same:

vim.defer_fn(function()
  vim.api.nvim_echo({{" ", "LTInfo"}}, false, {})
end, 100)

I'm not saying this is the issue, but it is a shot in a dark. Anything happens after that you can't do anything about anyway.

@ldelossa
Copy link
Owner

Hmm. I thought we remove any echo commands that would happen on startup.

When gh.nvim starts, it will call out to the ghcli to cache the current user info, but, we no longer create a echo for that. I can take a deeper look however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants