Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonjs / Browserify #166

Closed
jieter opened this issue Jun 10, 2015 · 3 comments · Fixed by #172
Closed

Commonjs / Browserify #166

jieter opened this issue Jun 10, 2015 · 3 comments · Fixed by #172

Comments

@jieter
Copy link
Contributor

jieter commented Jun 10, 2015

With #162, we have AMD support.

Do we need to add:

    // define a Common JS module that relies on 'leaflet'
    } else if (typeof exports === 'object') {
        module.exports = factory(require('leaflet'));
    }
@brunob
Copy link
Member

brunob commented Jun 11, 2015

no idea sorry :\

@calvinmetcalf
Copy link
Member

you want to check that both module and exports exist

@jieter
Copy link
Contributor Author

jieter commented Jun 11, 2015

Hmm, sorry for my question being unclear, I intended to ask about the need of implementing the commonjs module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants