AMD support #162
Merged
AMD support #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can consider this if done properly. Please update the pull and make sure travis is happy too. |
|
Looks like your last commit to master has broken the tests as it is trying to use the same protocol to load leaflet from the cdn but the protocol in the tests is file:// |
|
Thanks for noticing, fixed in #165 |
|
@dpix looks good, let's merge! |
|
released v1.1.0 |
|
Next time it would be nice if you can squash the commits into one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be awesome to have AMD support for this plugin. I've hacked in a fix but it would be cool to have proper amd support added, I.E. checking for existence of require etc