-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scss_formatter_compressed doesn't strip CSS comments #60
Comments
I'm not up on the sass spec, but I don't think all formatters need to follow it. If we want a formatter that outputs in CSSHaiku, that should be an option. I would make sense, though, to be an extension of the I don't know how related this is, but I notice that when I use the compress formatter, the normal comments (/* */) of all the |
I have a temporary working branch that adds an option to remove CSS comments from the output laying around for several months. In this patch, stripping comments is enabled only for the Before opening a PR, it'd like to address ticket #63 and make sure it's desired to enhance the default compressed formatter or introduce a whole new formatter instead. In particular, there are a whole lot of other enhancements and CSS minimizations in this branch (feel free to take a look), which I'd like to see merged back to the master at some point. |
+1 for a new formatter |
Hi, |
I've added the scss_formatter_crunched class to the develop branch. |
@Colir programmatically:
Using pscss:
|
Thanks |
When you use the scss_formatter_compressed flag, scss comments are stripped (the // type), but regular CSS comments ( /**/ style) are left in the CSS.
From what I understand this is expected SASS behavior. But when you compress the CSS output, shouldn't it be as small as possible?
The text was updated successfully, but these errors were encountered: