Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC 函数定义漏掉了处理中间阶段的 err #44

Closed
weakish opened this issue Oct 25, 2021 · 1 comment
Closed

RPC 函数定义漏掉了处理中间阶段的 err #44

weakish opened this issue Oct 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@weakish
Copy link
Contributor

weakish commented Oct 25, 2021

工单 38664 反馈 engine 的 RPC 方法 定义中没有处理当中 callCloudFunction 返回的 err

func (engine *engine) RPC(name string, params interface{}, results interface{}, runOptions ...RunOption) error {
	response, err := callCloudFunction(engine.client(), name, params, (append(runOptions, &runOption{
		rpc:    true,
		engine: engine,
	}))...)

	if err := bind(reflect.Indirect(reflect.ValueOf(response)), reflect.Indirect(reflect.ValueOf(results))); err != nil {
		return nil
	}

	return err
}

我看了下,client 上的 RPC 方法也有这个问题

@weakish weakish added the bug Something isn't working label Oct 25, 2021
@jysperm
Copy link
Contributor

jysperm commented Oct 28, 2021

已在 #46 修复

@weakish weakish closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants