Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support request filters #150

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Support request filters #150

merged 1 commit into from
Oct 13, 2020

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Oct 13, 2020

I assume it was simply some kind of laziness that the request filter functionality is not implemented currently.

Fixes #149

* request filters are applied one after another

Fixes leanovate#149
@dgoetsch
Copy link

LGTM

@avdv avdv requested a review from yanns October 13, 2020 17:38
Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no filter when this library was born 😉
Thanks for adding support for it!

@avdv avdv merged commit ec31d53 into leanovate:master Oct 13, 2020
@avdv avdv deleted the request-filters branch October 13, 2020 19:16
@perryjp
Copy link

perryjp commented May 6, 2021

@avdv or @yanns , is it possible to get a release cut with this change? Thanks so much!

@avdv
Copy link
Collaborator Author

avdv commented May 7, 2021

@perryjp I'll see if I can do it this weekend...

@perryjp
Copy link

perryjp commented May 7, 2021

Thanks, really appreciate it!

@avdv
Copy link
Collaborator Author

avdv commented May 8, 2021

@perryjp I pushed out release 2.8.1, could take a while until it shows up in the repository AFAIK.

@perryjp
Copy link

perryjp commented May 10, 2021

Yeah, wasn't there right away but I see it now. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FakeWSRequestHolder should support filters
4 participants