chore: fix bug in ext when introducing multiple patterns per lemma #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
commented
Jun 18, 2023
|
|
||
| example : 3 = 7 := by | ||
| ext n m : 1 | ||
| guard_target = n = m |
There was a problem hiding this comment.
Before this change, this step failed, as the goal was \forall m, n = m.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 23, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 23, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
utensil
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 26, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
Louddy
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
atarnoam
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
uniwuni
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 19, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
This PR contains 2 changes: 1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes. 2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159). 3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1. Partially addresses #11182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.