Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: fix some @[ext] attribute #11494

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: fix some @[ext] attribute #11494

wants to merge 1 commit into from

Conversation

casavaca
Copy link
Collaborator

@casavaca casavaca commented Mar 19, 2024 •
edited by eric-wieser

This PR contains 2 changes:

  1. Order/Interval.lean: Add @[ext (flat := false)], which addressed the porting notes.
  2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in chore: fix bug in ext when introducing multiple patterns per lemma batteries#159).
  3. Algebra/Order/Interval.lean updated now that ext_iff's namespace is changed due to 1.

Partially addresses #11182

Open in Gitpod

@casavaca casavaca added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Mar 19, 2024
grunweg
grunweg reviewed Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable; thank you for doing this.
I haven't verified that the newly generated ext lemma matches the previous, manually written one. (If you have, this would be useful to know.)

@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 23, 2024
@casavaca
chore: fix some @[ext] attribute (#11494)
fe6230c 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 23, 2024

Build failed:

@eric-wieser
Copy link
Member

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 23, 2024

✌️ casavaca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@casavaca
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 23, 2024
@casavaca
chore: fix some @[ext] attribute (#11494)
76e46f2 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix some @[ext] attribute [Merged by Bors] - chore: fix some @[ext] attribute Mar 23, 2024
@mathlib-bors mathlib-bors bot closed this Mar 23, 2024
@mathlib-bors mathlib-bors bot deleted the user_casavaca_2 branch March 23, 2024 19:58
utensil pushed a commit that referenced this pull request Mar 26, 2024
@casavaca @utensil
chore: fix some @[ext] attribute (#11494)
4d94ee4 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@casavaca @Louddy
chore: fix some @[ext] attribute (#11494)
f996ab7 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@casavaca @atarnoam
chore: fix some @[ext] attribute (#11494)
30b27a3 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@casavaca @uniwuni
chore: fix some @[ext] attribute (#11494)
0ae9bff 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@casavaca @callesonne
chore: fix some @[ext] attribute (#11494)
db31ce7 
This PR contains 2 changes:

1. Order/Interval.lean: Add `@[ext (flat := false)]`, which addressed the porting notes.
2. Matrix/Basic.lean: the porting notes were no longer true, as everything still works after reverting to the original code (this was fixed in leanprover-community/batteries#159).
3. Algebra/Order/Interval.lean updated now that `ext_iff`'s namespace is changed due to 1.

Partially addresses #11182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg approved these changes

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casavaca @eric-wieser @grunweg