-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(category_theory/sites/compatible_*): Compatibility of plus and sheafification with composition. #10510
Conversation
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
|
||
/-- The isomorphism between the sheafification of `P` composed with `F` and | ||
the sheafification of `P ⋙ F`. -/ | ||
def sheafify_comp_iso : J.sheafify P ⋙ F ≅ J.sheafify (P ⋙ F) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all these defs come with simps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how useful these would be in practice. I think it would be much more useful to relate these isomorphism to sheafify_lift
, but that requires additional assumptions to know that sheafification is a sheaf. What do you propose? I could add such lemmas in a separate section with these additional hypotheses, but I think simply adding simps
here would generate lemmas that unfold things "too much".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added lemmas relating hom and inv of this construction to sheafify_lift and to to_sheafify, as well as some simp lemmas reducing the other isomorphisms in this file to these cases... take a look toward the bottom of the file.
✌️ adamtopaz can now approve this pull request. To approve and merge a pull request, simply reply with |
bors d- @jcommelin could you take another quick look when you have time? The last changes I made were not so trivial... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
…heafification with composition. (#10510) Compatibility of sheafification with composition. This will be used later to obtain adjunctions between categories of sheaves.
Pull request successfully merged into master. Build succeeded: |
…heafification with composition. (#10510) Compatibility of sheafification with composition. This will be used later to obtain adjunctions between categories of sheaves.
Compatibility of sheafification with composition. This will be used later to obtain adjunctions between categories of sheaves.