This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/group/with_one): make with_one and with_zero irreducible. #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangingechen
changed the title
kbuzzard
added
the
awaiting-review
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
|
Shall I do the same with |
kbuzzard
added
awaiting-review
|
If you have the energy (-; But maybe in another PR? |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make
with_zeroandwith_oneirreducible.Arguments for: currently the simplifier will apply
with_onelemmas towith_zeroterms, causing "false positives" with the simp linter. Sometimes these are good (if the goal gets closed), but sometimes the goal state is in some sense corrupted. Making these irreducible stops this happening.Arguments against: one will need to duplicate some API -- so far I didn't need to duplicate anything though because a lot was duplicated already.
I was surprised how little of mathlib this broke. If people are generally enthusiastic about the idea then we could also make
with_topandwith_botirreducible.This idea was suggested by Johan in #3716 (comment) .
Zulip chat: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.22bug.22.20in.20.60simp.60.3F/near/207319933