Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/zsqrtd/to_real): Add to_real #5640

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat(data/zsqrtd/to_real): Add to_real #5640

wants to merge 13 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 6, 2021 •
edited
Loading

Also adds norm_eq_zero, and replaces some calls to simp with direct lemma applications

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Jan 6, 2021
digama0
digama0 reviewed Jan 6, 2021
View reviewed changes
src/data/zsqrtd/basic.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser changed the title feat(data/zsqrtd/basic): Add to_real feat(data/zsqrtd/to_real): Add to_real Jan 6, 2021
@jcommelin
Copy link
Member

Hah, you just beat me on lift_injective.

@eric-wieser
Copy link
Member Author

Well, thanks for golfing it anyway!

@eric-wieser @bryangingechen
Update src/data/zsqrtd/to_real.lean
85d4f94 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
jcommelin
jcommelin reviewed Jan 7, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace the coe_injective by a [char_zero R] assumption?

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 7, 2021
@eric-wieser
Copy link
Member Author

Probably, but then we need to translate between injectivity of (coe : ℤ → R) and (coe : \N → R). If you want that generalization, would you mind finishing it off?

@jcommelin
Copy link
Member

I'll try to find some time for it soon.

@jcommelin
Copy link
Member

Soon being 9 days... sorry

@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2021
@eric-wieser
Copy link
Member Author

Thanks @jcommelin, looks good to me. I have a small comment suggestion, but fine with or without it.

@jcommelin
Copy link
Member

@eric-wieser It's still your PR! Feel free to edit it as you like!

@eric-wieser
Copy link
Member Author

Well at this point it barely resembles my initial attempt, and the whole thing was motivated by trying to help Lars on Zulip! I've committed the comment change.

@eric-wieser eric-wieser requested review from jcommelin and removed request for jcommelin January 18, 2021 12:13
@bryangingechen
Copy link
Collaborator

@digama0 any final comments?

Vierkantor
Vierkantor approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since @digama0 hasn't objected, I think this should be fine to merge.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 27, 2021
@digama0
Copy link
Member

digama0 commented Jan 27, 2021

Oops! LGTM

bors bot pushed a commit that referenced this pull request Jan 27, 2021
@eric-wieser @jcommelin
feat(data/zsqrtd/to_real): Add to_real (#5640)
32fdb81 
Also adds `norm_eq_zero`, and replaces some calls to simp with direct lemma applications



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/zsqrtd/to_real): Add to_real [Merged by Bors] - feat(data/zsqrtd/to_real): Add to_real Jan 27, 2021
@bors bors bot closed this Jan 27, 2021
@bors bors bot deleted the eric-wieser/zsrqtd-real branch January 27, 2021 21:59
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@eric-wieser @jcommelin @b-mehta
feat(data/zsqrtd/to_real): Add to_real (#5640)
f1b4cf9 
Also adds `norm_eq_zero`, and replaces some calls to simp with direct lemma applications



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@jcommelin jcommelin jcommelin left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

@kbuzzard kbuzzard Awaiting requested review from kbuzzard

@digama0 digama0 Awaiting requested review from digama0

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eric-wieser @jcommelin @bryangingechen @digama0 @Vierkantor