Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - split(analysis/convex/combination): split off analysis.convex.basic #9115

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - split(analysis/convex/combination): split off analysis.convex.basic #9115

wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Sep 9, 2021 •
edited

This moves finset.center_mass into its own new file.

About the copyright header, finset.center_mass comes from #1804, which was written by Yury in December 2019.

This can through right now with the convexity refactor.
Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Sep 9, 2021
fpvandoorn
fpvandoorn reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also adds set.finite.convex_hull_eq_image and mem_Icc_of_mem_std_simplex, right?

Can you update the module doc of convex/basic?

@YaelDillies
Copy link
Collaborator Author

Oh whoops, my change to the module docstring got lost in branch translation.

Yes, those two lemmas use finset.center_mass in their proof, so I had to move them.

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 10, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 10, 2021
@fpvandoorn
Copy link
Member

The module doc of convex.basic still mentions Jensen's inequality.

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 11, 2021
bors bot pushed a commit that referenced this pull request Sep 11, 2021
@YaelDillies
split(analysis/convex/combination): split off analysis.convex.basic (…
b9ad733 
…#9115)

This moves `finset.center_mass` into its own new file.

About the copyright header, `finset.center_mass` comes from #1804, which was written by Yury in December 2019.
@bors
Copy link

bors bot commented Sep 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title split(analysis/convex/combination): split off analysis.convex.basic [Merged by Bors] - split(analysis/convex/combination): split off analysis.convex.basic Sep 11, 2021
@bors bors bot closed this Sep 11, 2021
@bors bors bot deleted the yael/center_mass branch September 11, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YaelDillies @fpvandoorn