[Merged by Bors] - feat(algebra/direct_sum/module) : coe and internal #10004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
eric-wieser
reviewed
Oct 27, 2021
eric-wieser
reviewed
Oct 27, 2021
eric-wieser
added
awaiting-review
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jjaassoonn
removed
the
awaiting-author
eric-wieser
reviewed
Oct 27, 2021
eric-wieser
reviewed
Oct 27, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
This looks good to me now, thanks. @kbuzzard, @jcommelin: do these names look reasonable to you? |
eric-wieser
added
the
awaiting-review
eric-wieser
reviewed
Oct 28, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jcommelin
reviewed
Oct 28, 2021
src/algebra/direct_sum/basic.lean
Outdated
| @@ -172,13 +172,23 @@ protected def id (M : Type v) (ι : Type* := punit) [add_comm_monoid M] [unique | |||
| right_inv := λ x, to_add_monoid_of _ _ _, | |||
| ..direct_sum.to_add_monoid (λ _, add_monoid_hom.id M) } | |||
|
|
|||
| /-- The canonical embedding from `⨁ i, A i` to `M`-/ | |||
There was a problem hiding this comment.
I think that this docstring should mention that the A i are submonoids of M.
There was a problem hiding this comment.
Thank you for the suggestion
src/algebra/direct_sum/basic.lean
Outdated
Comment on lines
178
to
183
| direct_sum.to_add_monoid (λ i, (A i).subtype) | ||
|
|
||
| @[simp] lemma add_submonoid_coe_of {M : Type*} [decidable_eq ι] [add_comm_monoid M] | ||
| (A : ι → add_submonoid M) (i : ι) (x : A i) : | ||
| direct_sum.add_submonoid_coe A (direct_sum.of (λ i, A i) i x) = x := | ||
| direct_sum.to_add_monoid_of _ _ _ |
There was a problem hiding this comment.
Aren't you in the direct_sum namespace? So I guess you can remove some (all?) of these direct_sum. prefixes.
There was a problem hiding this comment.
Thank you for the suggestion
src/algebra/direct_sum/basic.lean
Outdated
| @@ -188,13 +198,23 @@ begin | |||
| exact function.bijective.surjective h, | |||
| end | |||
|
|
|||
| /-- The canonical embedding from `⨁ i, A i` to `M`-/ | |||
src/algebra/direct_sum/module.lean
Outdated
| @@ -194,6 +194,17 @@ lemma component.of (i j : ι) (b : M j) : | |||
| if h : j = i then eq.rec_on h b else 0 := | |||
| dfinsupp.single_apply | |||
|
|
|||
| /-- The canonical embedding from `⨁ i, A i` to `M`-/ | |||
jcommelin
added
awaiting-author
jjaassoonn
added
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
This extracts the following `def`s from within the various `is_internal` properties: * `direct_sum.add_submonoid_coe` * `direct_sum.add_subgroup_coe` * `direct_sum.submodule_coe` Packing these into a def makes things more concise, and avoids some annoying elaboration issues. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: jjaassoonn <jujian.zhang1998@out.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
This extracts the following `def`s from within the various `is_internal` properties: * `direct_sum.add_submonoid_coe` * `direct_sum.add_subgroup_coe` * `direct_sum.submodule_coe` Packing these into a def makes things more concise, and avoids some annoying elaboration issues. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: jjaassoonn <jujian.zhang1998@out.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the following
defs from within the variousis_internalproperties:direct_sum.add_submonoid_coedirect_sum.add_subgroup_coedirect_sum.submodule_coePacking these into a def makes things more concise, and avoids some annoying elaboration issues.
Co-authored-by: Eric Wieser wieser.eric@gmail.com