[Merged by Bors] - feat(ring_theory/graded_algebra): projection map of graded algebra #10116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
blocked-by-other-PR
8 tasks
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…munity/mathlib into graded_ring_dep_2
3 tasks
eric-wieser
reviewed
Dec 5, 2021
eric-wieser
reviewed
Dec 5, 2021
src/algebra/direct_sum/internal.lean
Outdated
| @@ -77,6 +77,24 @@ direct_sum.to_semiring (λ i, (A i).subtype) rfl (λ _ _ _ _, rfl) | |||
| direct_sum.submonoid_coe_ring_hom A (direct_sum.of (λ i, A i) i x) = x := | |||
| direct_sum.to_semiring_of _ _ _ _ _ | |||
|
|
|||
| section big_operators | |||
|
|
|||
| open_locale big_operators | |||
There was a problem hiding this comment.
I think it's fine to just do this at the top of the file, and then get rid of the section
eric-wieser
reviewed
Dec 5, 2021
eric-wieser
reviewed
Dec 5, 2021
eric-wieser
approved these changes
Dec 5, 2021
|
✌️ jjaassoonn can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Thank you, Eric! bors r+ |
|
Canceled. |
|
I pushed one missed style change (edit: and two more I didn't comment on). Let's wait for CI before merging. |
|
I also combined two |
jjaassoonn
removed
the
awaiting-author
Also should fix a lint error
|
bors merge Looks like the linter is finally happy |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 5, 2021
…10116) This pr defines and proves some property about `graded_algebra.proj : A →ₗ[R] A` Co-authored-by: jjaassoonn <jujian.zhang1998@out.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
Dec 18, 2021
…10116) This pr defines and proves some property about `graded_algebra.proj : A →ₗ[R] A` Co-authored-by: jjaassoonn <jujian.zhang1998@out.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr defines and proves some property about
graded_algebra.proj : A →ₗ[R] Agraded_algebra#10115