Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): Cone limiting iff terminal. #10266

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits): Cone limiting iff terminal. #10266

wants to merge 4 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Nov 11, 2021

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Nov 11, 2021
@erdOne erdOne mentioned this pull request Nov 11, 2021
Closed
1 task
@erdOne erdOne added this to Pending review in Algebraic geometry Nov 11, 2021
jcommelin
jcommelin reviewed Nov 11, 2021
View reviewed changes
src/category_theory/limits/cone_category.lean Outdated Show resolved Hide resolved
src/category_theory/limits/cone_category.lean Outdated Show resolved Hide resolved
src/category_theory/limits/cone_category.lean Outdated Show resolved Hide resolved
src/category_theory/limits/cone_category.lean Outdated Show resolved Hide resolved
src/category_theory/limits/preserves/shapes/terminal.lean Outdated Show resolved Hide resolved
src/category_theory/limits/preserves/shapes/terminal.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 11, 2021
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 11, 2021
jcommelin
jcommelin approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 12, 2021
bors bot pushed a commit that referenced this pull request Nov 12, 2021
@erdOne
feat(category_theory/limits): Cone limiting iff terminal. (#10266)
d7e320e
@bors
Copy link

bors bot commented Nov 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): Cone limiting iff terminal. [Merged by Bors] - feat(category_theory/limits): Cone limiting iff terminal. Nov 12, 2021
@bors bors bot closed this Nov 12, 2021
Algebraic geometry automation moved this from Pending review to Done Nov 12, 2021
@bors bors bot deleted the cone_category branch November 12, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Algebraic geometry
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erdOne @jcommelin