Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/discriminant): add the discriminant of a family of vectors #10350

Closed
wants to merge 85 commits into from
Closed

[Merged by Bors] - feat(ring_theory/discriminant): add the discriminant of a family of vectors #10350

wants to merge 85 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Nov 16, 2021 •
edited by github-actions bot

We add the definition and some basic results about the discriminant.

From FLT-regular.

Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Nov 16, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 16, 2021
eric-wieser and others added 13 commits November 16, 2021 21:45
@eric-wieser
feat(linear_algebra/bilinear_form): add lemmas about congr
c071f2a
@riccardobrasca
golf
37be1c8
@riccardobrasca @eric-wieser
Update src/linear_algebra/bilinear_form.lean
1e194e7 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca @eric-wieser
Update src/linear_algebra/bilinear_form.lean
848cde4 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca @eric-wieser
Update src/linear_algebra/bilinear_form.lean
877a840 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca
Merge remote-tracking branch 'origin/eric-wieser/bilin_form.congr_lem…
ba94090 
…mas' into RB_bilinear
@riccardobrasca
add congr_nondegenerate_iff and golf
36d0f30
@riccardobrasca
add nondegenerate_iff_det_ne_zero
0f999a1
@riccardobrasca
Merge remote-tracking branch 'origin/RB_bilinear' into RB_discriminant
706966f
@riccardobrasca
useless assumption
d82b76c
@riccardobrasca
Merge remote-tracking branch 'origin/RB_bilinear' into RB_discriminant
b1b7ba9
@riccardobrasca
fix build
2753766
@eric-wieser
Merge branch 'master' into RB_bilinear
bef970f
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 17, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 17, 2021
riccardobrasca and others added 3 commits December 7, 2021 16:17
@riccardobrasca
fix build
450ba1c
@riccardobrasca
fix build
1463c61
@Vierkantor
refactor(data/matrix): reverse the direction of matrix.minor_mul_equiv
b9e430f 
In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change `reindex_linear_equiv_mul`, which is similarly much more popular backwards than forwards.

Closes: #10638
@Vierkantor Vierkantor mentioned this pull request Dec 7, 2021
Closed
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 8, 2021
YaelDillies
YaelDillies reviewed Dec 8, 2021
View reviewed changes
src/ring_theory/discriminant.lean Outdated Show resolved Hide resolved
src/ring_theory/discriminant.lean Outdated Show resolved Hide resolved
src/ring_theory/discriminant.lean Outdated Show resolved Hide resolved
riccardobrasca and others added 3 commits December 8, 2021 14:43
@riccardobrasca @YaelDillies
Update src/ring_theory/discriminant.lean
abc00c0 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@riccardobrasca @YaelDillies
Update src/ring_theory/discriminant.lean
b777971 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@riccardobrasca
doc
7cc9aaf
bors bot pushed a commit that referenced this pull request Dec 8, 2021
@Vierkantor
refactor(data/matrix): reverse the direction of `matrix.minor_mul_equ…
5969490 
…iv` (#10657)

In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change `reindex_linear_equiv_mul`, which is similarly much more popular backwards than forwards.

Closes: #10638
bors bot pushed a commit that referenced this pull request Dec 8, 2021
@Vierkantor
refactor(data/matrix): reverse the direction of `matrix.minor_mul_equ…
baab5d3 
…iv` (#10657)

In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change `reindex_linear_equiv_mul`, which is similarly much more popular backwards than forwards.

Closes: #10638
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

jcommelin
jcommelin reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to remove of_ from the discr_of_power_basis_eq_prod name. Otherwise, let's get this in mathlib!

bors d+

src/ring_theory/discriminant.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 10, 2021

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 10, 2021
@riccardobrasca @jcommelin
Update src/ring_theory/discriminant.lean
3dccbfa 
Co-authored-by: Johan Commelin <johan@commelin.net>
@riccardobrasca
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 10, 2021
@riccardobrasca @eric-wieser
feat(ring_theory/discriminant): add the discriminant of a family of v…
b7ac833 
…ectors (#10350)

We add the definition and some basic results about the discriminant.

From FLT-regular.

- [x] depends on: #10657 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Dec 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/discriminant): add the discriminant of a family of vectors [Merged by Bors] - feat(ring_theory/discriminant): add the discriminant of a family of vectors Dec 10, 2021
@bors bors bot closed this Dec 10, 2021
@bors bors bot deleted the RB_discriminant branch December 10, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@alexjbest alexjbest alexjbest left review comments

@jcommelin jcommelin jcommelin left review comments

@YaelDillies YaelDillies YaelDillies left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@riccardobrasca @eric-wieser @alexjbest @Vierkantor @jcommelin @YaelDillies