Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(data/matrix): reverse the direction of matrix.minor_mul_equiv #10657

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - refactor(data/matrix): reverse the direction of matrix.minor_mul_equiv #10657

wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change reindex_linear_equiv_mul, which is similarly much more popular backwards than forwards.

Closes: #10638

Open in Gitpod

@Vierkantor
refactor(data/matrix): reverse the direction of matrix.minor_mul_equiv
b9e430f 
In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change `reindex_linear_equiv_mul`, which is similarly much more popular backwards than forwards.

Closes: #10638
@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Dec 7, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 7, 2021
riccardobrasca
riccardobrasca approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riccardobrasca riccardobrasca mentioned this pull request Dec 8, 2021
Closed
2 tasks
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 8, 2021
bors bot pushed a commit that referenced this pull request Dec 8, 2021
@Vierkantor
refactor(data/matrix): reverse the direction of `matrix.minor_mul_equ…
5969490 
…iv` (#10657)

In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change `reindex_linear_equiv_mul`, which is similarly much more popular backwards than forwards.

Closes: #10638
@bors
Copy link

bors bot commented Dec 8, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 8, 2021
@Vierkantor
refactor(data/matrix): reverse the direction of `matrix.minor_mul_equ…
baab5d3 
…iv` (#10657)

In #10350 this change was proposed, since we apparently use that backwards way more than we use it forwards.

We also change `reindex_linear_equiv_mul`, which is similarly much more popular backwards than forwards.

Closes: #10638
@bors
Copy link

bors bot commented Dec 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/matrix): reverse the direction of matrix.minor_mul_equiv [Merged by Bors] - refactor(data/matrix): reverse the direction of matrix.minor_mul_equiv Dec 9, 2021
@bors bors bot closed this Dec 9, 2021
@bors bors bot deleted the reverse_minor_mul_equiv branch December 9, 2021 00:11
bors bot pushed a commit that referenced this pull request Dec 10, 2021
@riccardobrasca @eric-wieser
feat(ring_theory/discriminant): add the discriminant of a family of v…
b7ac833 
…ectors (#10350)

We add the definition and some basic results about the discriminant.

From FLT-regular.

- [x] depends on: #10657 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should matrix.minor_mul_equiv be stated in reverse and marked @[simp]?
4 participants
@Vierkantor @robertylewis @eric-wieser @riccardobrasca