Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/convex/strict): Strictly convex sets #10648

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(analysis/convex/strict): Strictly convex sets #10648

wants to merge 11 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Dec 6, 2021 •
edited by github-actions bot

This defines strictly convex sets.

This is yet again an almost exact copy of analysis.convex.basic. Next step is to define strictly convex spaces.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Dec 6, 2021
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Dec 7, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 8, 2021
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 9, 2021
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 12, 2021
jcommelin
jcommelin approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 13, 2021
bors bot pushed a commit that referenced this pull request Dec 13, 2021
@YaelDillies
feat(analysis/convex/strict): Strictly convex sets (#10648)
ec48e3b 
This defines strictly convex sets.
@bors
Copy link

bors bot commented Dec 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/convex/strict): Strictly convex sets [Merged by Bors] - feat(analysis/convex/strict): Strictly convex sets Dec 13, 2021
@bors bors bot closed this Dec 13, 2021
@bors bors bot deleted the strict_convex branch December 13, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@ADedecker ADedecker ADedecker left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @urkud @jcommelin @ADedecker