Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/algebra/group): Addition of interiors #10659

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(topology/algebra/group): Addition of interiors #10659

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This proves interior s * t ⊆ interior (s * t), a few prerequisites, and generalizes to is_open.mul_left/is_open.mul_right.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Dec 7, 2021
@YaelDillies YaelDillies mentioned this pull request Dec 7, 2021
Closed
1 task
ADedecker
ADedecker reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the commutativity assumption

src/topology/algebra/group.lean Outdated Show resolved Hide resolved
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 7, 2021
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 7, 2021
urkud
urkud reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few golfing suggestions, otherwise LGTM.
bors d+

src/data/set/basic.lean Outdated Show resolved Hide resolved
src/data/set/basic.lean Outdated Show resolved Hide resolved
src/topology/algebra/group.lean Outdated Show resolved Hide resolved
src/topology/algebra/group.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 8, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 8, 2021
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 8, 2021
@YaelDillies
feat(topology/algebra/group): Addition of interiors (#10659)
678566f 
This proves `interior s * t ⊆ interior (s * t)`, a few prerequisites, and generalizes to `is_open.mul_left`/`is_open.mul_right`.
@bors
Copy link

bors bot commented Dec 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/algebra/group): Addition of interiors [Merged by Bors] - feat(topology/algebra/group): Addition of interiors Dec 8, 2021
@bors bors bot closed this Dec 8, 2021
@bors bors bot deleted the interior_mul branch December 8, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@ADedecker ADedecker ADedecker approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @urkud @ADedecker