Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topology/algebra/open_subgroup): basics on open subgroups #1067

Merged
merged 9 commits into from May 31, 2019

Conversation

jcommelin
Copy link
Member

From the perfectoid project.
Depends on #1066.
Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/open.20subgroups

@jcommelin jcommelin requested a review from a team as a code owner May 20, 2019 19:21
@sgouezel
Copy link
Collaborator

This looks very good and very clean, except maybe the comment on Line 99 that you should remove. I have a question related to this comment: do you understand why the to_additive machinery sometimes works directly out of the box, and why sometimes you need to reprove the statements? Is that a hint that some previous lemmas are not tagged correctly, or simply that the machinery is not powerful enough?

@digama0
Copy link
Member

digama0 commented May 30, 2019

The to_additive machinery is sometimes too aggressive in replacing multiplicative stuff with additive. In particular, whenever group_power gets involved, nat gets involved, and then you might not want to turn 1 : nat into 0 : nat and such, when you are trying to make the group A additive. I'm not sure if any such examples appear in this PR, though; mostly I discover the offenders by trial and error, although to_additive errors also tell you where to put more annotations.

@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 31, 2019
@mergify mergify bot merged commit 4f6307e into master May 31, 2019
@mergify mergify bot deleted the open-subgroups branch May 31, 2019 21:00
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…rover-community#1067)

* Dump the file into mathlib

* feat(algebra/pi_instances): product of submonoids/groups/rings

From the perfectoid project.

* Small changes

* feat(topology/algebra/open_subgroup): basics on open subgroups

* Some proof compression

* Update src/topology/algebra/open_subgroup.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants