Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_eq_cyclotomic_mul #11005

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_eq_cyclotomic_mul #11005

wants to merge 21 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Dec 23, 2021 •
edited by github-actions bot

We prove that, if ¬p ∣ n, then expand R p (cyclotomic n R) = (cyclotomic (n * p) R) * (cyclotomic n R)

Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Dec 23, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 23, 2021
@ericrbg ericrbg changed the title Feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_epand_eq_cyclotomic_mul feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_eq_cyclotomic_mul Dec 23, 2021
riccardobrasca and others added 3 commits December 23, 2021 16:42
@riccardobrasca @ericrbg
Update src/ring_theory/polynomial/cyclotomic/basic.lean
a72e1b9 
Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@riccardobrasca
golf
c4d039f
@riccardobrasca
golf
cfbe1d0
ericrbg
ericrbg approved these changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm!

src/ring_theory/polynomial/cyclotomic/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/polynomial/cyclotomic/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/polynomial/cyclotomic/basic.lean Outdated Show resolved Hide resolved
riccardobrasca and others added 4 commits December 23, 2021 18:24
@riccardobrasca @ericrbg
Update src/ring_theory/polynomial/cyclotomic/basic.lean
e870de3 
Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@riccardobrasca
better name
ab3ea85
@riccardobrasca
golf
89f6831
@riccardobrasca
doc
4cbf78c
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 23, 2021
@github-actions
Copy link

This PR/issue depends on:

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 27, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 28, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 28, 2021
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 28, 2021
jcommelin
jcommelin approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 30, 2021
bors bot pushed a commit that referenced this pull request Dec 30, 2021
@riccardobrasca
feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_…
52841fb 
…eq_cyclotomic_mul (#11005)

We prove that, if `¬p ∣ n`, then `expand R p (cyclotomic n R) = (cyclotomic (n * p) R) * (cyclotomic n R)`

- [x] depends on: #10965
@bors
Copy link

bors bot commented Dec 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_eq_cyclotomic_mul [Merged by Bors] - feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_eq_cyclotomic_mul Dec 30, 2021
@bors bors bot closed this Dec 30, 2021
@bors bors bot deleted the RB_cycl_lemma branch December 30, 2021 14:54
erdOne pushed a commit that referenced this pull request Jan 1, 2022
@riccardobrasca @erdOne
feat(ring_theory/polynomial/cyclotomic/basic): add cyclotomic_expand_…
0a69147 
…eq_cyclotomic_mul (#11005)

We prove that, if `¬p ∣ n`, then `expand R p (cyclotomic n R) = (cyclotomic (n * p) R) * (cyclotomic n R)`

- [x] depends on: #10965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@ericrbg ericrbg ericrbg approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardobrasca @jcommelin @ericrbg