[Merged by Bors] - split(algebra/big_operators/multiset): Split off data.multiset.basic
#11043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
2 tasks
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2021
#11043) This moves * `multiset.prod`, `multiset.sum` to `algebra.big_operators.multiset` * `multiset.join`, `multiset.bind`, `multiset.product`, `multiset.sigma` to `data.multiset.bind`. This is needed as `join` is defined using `sum`. The file was quite messy, so I reorganized `algebra.big_operators.multiset` by increasing typeclass assumptions. I'm crediting Mario for 0663945 (`prod`, `sum`, `join`), f9de183 (`bind`, `product`), 16d40d7 (`sigma`).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
data.multiset.basicdata.multiset.basic
erdOne
pushed a commit
that referenced
this pull request
Jan 1, 2022
#11043) This moves * `multiset.prod`, `multiset.sum` to `algebra.big_operators.multiset` * `multiset.join`, `multiset.bind`, `multiset.product`, `multiset.sigma` to `data.multiset.bind`. This is needed as `join` is defined using `sum`. The file was quite messy, so I reorganized `algebra.big_operators.multiset` by increasing typeclass assumptions. I'm crediting Mario for 0663945 (`prod`, `sum`, `join`), f9de183 (`bind`, `product`), 16d40d7 (`sigma`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
multiset.prod,multiset.sumtoalgebra.big_operators.multisetmultiset.join,multiset.bind,multiset.product,multiset.sigmatodata.multiset.bind. This is needed asjoinis definedusing
sum.The file was quite messy, so I reorganized
algebra.big_operators.multisetby increasing typeclass assumptions.I'm crediting Mario for 0663945 (
prod,sum,join), f9de183 (bind,product), 16d40d7 (sigma).As a bonus, I additivized two or three statements on the go. but there are some more that I can't fix without scope-creeping so I marked them as TODO.