[Merged by Bors] - chore(algebra/ring/basic): generalize is_domain.to_cancel_monoid_with_zero to no_zero_divisors
#11387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_zero` to `no_zero_divisors` This generalization doesn't work for typeclass search, but it can be useful for a `letI` in another proof. Independent of whether this turns out to be useful, it's nice to show that nontriviality doesn't affect the fact that rings with no zero divisors are cancellative.
eric-wieser
added
the
awaiting-review
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
…h_zero` to `no_zero_divisors` (#11387) This generalization doesn't work for typeclass search as `cancel_monoid_with_zero` implies `no_zero_divisors` which would form a loop, but it can be useful for a `letI` in another proof. Independent of whether this turns out to be useful, it's nice to show that nontriviality doesn't affect the fact that rings with no zero divisors are cancellative.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
is_domain.to_cancel_monoid_with_zero to no_zero_divisorsis_domain.to_cancel_monoid_with_zero to no_zero_divisors
bors
bot
deleted the
eric-wieser/no_zero_divisors.to_cancel_monoid_with_zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalization doesn't work for typeclass search as
cancel_monoid_with_zeroimpliesno_zero_divisorswhich would form a loop, but it can be useful for aletIin another proof.Independent of whether this turns out to be useful, it's nice to show that nontriviality doesn't affect the fact that rings with no zero divisors are cancellative.