Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/ring/basic): generalize is_domain.to_cancel_monoid_with_zero to no_zero_divisors #11387

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(algebra/ring/basic): generalize is_domain.to_cancel_monoid_with_zero to no_zero_divisors #11387

wants to merge 1 commit into from

Commits on Jan 12, 2022

  1. chore(algebra/ring/basic): generalize `is_domain.to_cancel_monoid_wit… 

    …h_zero` to `no_zero_divisors`

This generalization doesn't work for typeclass search, but it can be useful for a `letI` in another proof.

Independent of whether this turns out to be useful, it's nice to show that nontriviality doesn't affect the fact that rings with no zero divisors are cancellative.
    @eric-wieser
    eric-wieser committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    baece3a View commit details
    Browse the repository at this point in the history