This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/pointwise): introduce canonically_ordered_comm_semiring on set_semiring ...
#11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-bot-assistant
added
the
blocked-by-other-PR
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
leanprover-community-bot-assistant
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
adomani
added
the
awaiting-review
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Yaël, thank you so much for your golfing suggestions! |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
…r-community/mathlib into adomani_set_semiring_can
|
That's great, thanks Yaël! Honestly, I no longer follow the Lean proofs entirely, but I also find the math proofs pretty trivial, so I do not mind the obfuscation! |
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
…` on `set_semiring` ... (#11580) ... assuming multiplication is commutative (there is no `canonically_ordered_`~~comm~~`_semiring` structure). Also prove the relevant `no_zero_divisors` and `covariant_class` properties of addition and multiplication. Co-authored-by: Damiano Testa <maskal@CLD-E854D68C.ads.warwick.ac.uk> Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
canonically_ordered_comm_semiring on set_semiring ...canonically_ordered_comm_semiring on set_semiring ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... assuming multiplication is commutative (there is no
canonically_ordered_comm_semiringstructure).Also prove the relevant
no_zero_divisorsandcovariant_classproperties of addition and multiplication.set_semiring#11567 [introducing the partial order onset_semiring]