[Merged by Bors] - feat(topology/algebra): Inf and inducing preserve compatibility with algebraic structure #11720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADedecker
added
the
awaiting-review
…ity/mathlib into AD_top_lattice_algebra
fpvandoorn
reviewed
Feb 1, 2022
There was a problem hiding this comment.
Without investigating very deeply, I think in earlier commits you had two problems:
- You were putting multiple
topological_groupinstances on the same type, which is never a good idea - I think type-class inference cannot deal with hypotheses of the form
[∀ t ∈ ts, @topological_group G t _]. Note that this depends on a hypothesis(H : t ∈ ts)which cannot be figured out itself by type-class inference.
These lemmas are fine, and can locally be used with haveI/letI.
One minor comment, otherwise, LGTM
bors d+
|
✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
…algebraic structure (#11720) This partly duplicates @mariainesdff 's work on group topologies, but I'm using an unbundled approach which avoids defining a new `X_topology` structure for each interesting X.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly duplicates @mariainesdff 's work on group topologies, but I'm using an unbundled approach which avoids defining a new
X_topologystructure for each interesting X.