Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/algebra): relax some Type* assumptions to Sort* #12058

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(topology/algebra): relax some Type* assumptions to Sort* #12058

wants to merge 1 commit into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Feb 15, 2022 •
edited
Loading

When working on #11720 I forgot that we have to deal with Prop-indexed infimums quite often, so this PR fixes that.

Open in Gitpod

@ADedecker ADedecker added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Feb 15, 2022
eric-wieser
eric-wieser approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 15, 2022
bors bot pushed a commit that referenced this pull request Feb 15, 2022
@ADedecker
feat(topology/algebra): relax some Type* assumptions to Sort* (#1…
eeb2956 
…2058)

When working on #11720 I forgot that we have to deal with Prop-indexed infimums quite often, so this PR fixes that.
@bors
Copy link

bors bot commented Feb 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/algebra): relax some Type* assumptions to Sort* [Merged by Bors] - feat(topology/algebra): relax some Type* assumptions to Sort* Feb 15, 2022
@bors bors bot closed this Feb 15, 2022
@bors bors bot deleted the AD_top_lattice_fix_sort branch February 15, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ADedecker @eric-wieser @leanprover-community-bot-assistant