Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): Miscellaneous lemmas in algebra #1188

Merged
merged 4 commits into from Jul 10, 2019
Merged

feat(*): Miscellaneous lemmas in algebra #1188

merged 4 commits into from Jul 10, 2019

Conversation

jcommelin
Copy link
Member

A bunch of tiny little lemmas, and some missing to_additive attributes.

Mostly from the perfectoid project.

@jcommelin jcommelin requested a review from a team as a code owner July 5, 2019 19:28
@@ -304,6 +304,14 @@ theorem sup_mul : (I ⊔ J) * K = I * K ⊔ J * K :=
submodule.sup_smul I J K
variables {I J K}

lemma pow_le_pow {m n : ℕ} (h : m ≤ n) :
I^n ≤ I^m :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called something with mono in ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that would make sense... but there are a lot of other lemmas with pow_le_pow in their name in mathlib. @digama0 Which convention would you prefer?
@cipher1024 Is this something that should be tagged with @[mono] or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ideals an ordered semiring?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll look into proving it tomorrow. (I guess submodules form an ordered semiring, and in the case of ideals everything is ≤ 1).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHughes24 Hmm, they are not.
https://github.com/leanprover-community/lean/blob/ec1613aef1eee72e601f192b16740629c6d49690/library/init/algebra/ordered_group.lean#L21 is not satisfied. Take any I and J, then 1 = I + 1 ≤ J + 1 = 1, but we can't conclude I ≤ J.

@ChrisHughes24 ChrisHughes24 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 10, 2019
@mergify mergify bot merged commit 5cdebb7 into master Jul 10, 2019
@mergify mergify bot deleted the algebra-misc branch July 10, 2019 21:33
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
* Trying things out

* feat(ring_theory/*): Misc little lemmas

* More little lemmas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants