New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(simplex_category): various epi/mono lemmas #11924
Conversation
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
I added a comment about those lemmas whose purpose was not immediately obvious to me. It seems to me that you could pretty much just delete all these lemmas with minor refactorings to the remaining ones (though I didn't look that closely) and make the "narrative" of the file more transparent. If you want these lemmas for later use, then maybe it would be better to add them as part of a later PR where the context is more clear. |
BTW, what's your plan for |
Thanks for the review. I have removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lemmas all look reasonable enough to me. What are you planning to do with this PR?
@joelriou, could you mark conversations as "resolved" where possible? It's easier for new reviewers to come in if we don't have to decipher which requested changes have and haven't been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Build failed (retrying...): |
Canceled. |
bors d+ Once you've merged master and it's building again, feel free to put it back on the queue. |
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
Various results are obtained about injective/bijective/surjective maps in
simplex_category
. In particular, non surjective maps factors through someδ
, and non injective maps factors through someσ
. (The next step after this PR shall be provinghas_strong_epi_mono_factorisation simplex_category
.)