Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(simplex_category): various epi/mono lemmas #11924

Closed
wants to merge 10 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Feb 8, 2022


Various results are obtained about injective/bijective/surjective maps in simplex_category. In particular, non surjective maps factors through some δ, and non injective maps factors through some σ. (The next step after this PR shall be proving has_strong_epi_mono_factorisation simplex_category.)

Open in Gitpod

@joelriou joelriou added the awaiting-review The author would like community review of the PR label Feb 8, 2022
joelriou and others added 2 commits February 10, 2022 11:51
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
src/algebraic_topology/simplex_category.lean Outdated Show resolved Hide resolved
src/algebraic_topology/simplex_category.lean Outdated Show resolved Hide resolved
src/algebraic_topology/simplex_category.lean Outdated Show resolved Hide resolved
@rwbarton
Copy link
Collaborator

I added a comment about those lemmas whose purpose was not immediately obvious to me. It seems to me that you could pretty much just delete all these lemmas with minor refactorings to the remaining ones (though I didn't look that closely) and make the "narrative" of the file more transparent. If you want these lemmas for later use, then maybe it would be better to add them as part of a later PR where the context is more clear.

@rwbarton
Copy link
Collaborator

BTW, what's your plan for has_strong_epi_mono_factorisation simplex_category? It seems like the easiest way might be to do the work in the non-skeletal version and then transport the factorization to simplex_category.

@joelriou
Copy link
Collaborator Author

joelriou commented Feb 10, 2022

Thanks for the review. I have removed the eq_to_iso/hom versions. I may have to add some of them back in the future, we'll see...
For the strong_epi_mono_factorisation, I had considered doing it first in NonemptyFinLinOrd, but it turned out it was as convenient to do it directly in simplex_category.

Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lemmas all look reasonable enough to me. What are you planning to do with this PR?

src/algebraic_topology/simplex_category.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator

@joelriou, could you mark conversations as "resolved" where possible? It's easier for new reviewers to come in if we don't have to decipher which requested changes have and haven't been made.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 3, 2022
bors bot pushed a commit that referenced this pull request Mar 3, 2022


Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 3, 2022

Build failed (retrying...):

@bors
Copy link

bors bot commented Mar 3, 2022

Canceled.

@eric-wieser
Copy link
Member

bors d+

Once you've merged master and it's building again, feel free to put it back on the queue.

@bors
Copy link

bors bot commented Mar 3, 2022

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Mar 3, 2022
@joelriou
Copy link
Collaborator Author

joelriou commented Mar 3, 2022

bors merge

bors bot pushed a commit that referenced this pull request Mar 3, 2022


Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 3, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(simplex_category): various epi/mono lemmas [Merged by Bors] - feat(simplex_category): various epi/mono lemmas Mar 3, 2022
@bors bors bot closed this Mar 3, 2022
@bors bors bot deleted the simplex_category_lemmas branch March 3, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants