Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/list/basic): list.prod_range_succ, list.sum_range_succ #1197

Merged
merged 6 commits into from Jul 10, 2019
Merged

feat(data/list/basic): list.prod_range_succ, list.sum_range_succ #1197

merged 6 commits into from Jul 10, 2019

Conversation

bryangingechen
Copy link
Collaborator

cf. finset.prod_range_succ in algebra.big_operators

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@bryangingechen bryangingechen requested a review from a team as a code owner July 9, 2019 03:04
cipher1024
cipher1024 reviewed Jul 9, 2019
View reviewed changes
src/data/list/basic.lean Outdated Show resolved Hide resolved
cipher1024
cipher1024 previously requested changes Jul 9, 2019
View reviewed changes
Copy link
Collaborator

@cipher1024 cipher1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation and brackets as mentioned next to the line

@ChrisHughes24 ChrisHughes24 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 10, 2019
@mergify mergify bot merged commit d2b4380 into master Jul 10, 2019
@mergify mergify bot deleted the list.prod_range_succ branch July 10, 2019 15:58
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@bryangingechen @anrddh
feat(data/list/basic): list.prod_range_succ, list.sum_range_succ (lea…
931f90e 
…nprover-community#1197)

* feat(data/list/basic): list.prod_range_succ, list.sum_range_succ

* changes from review

* remove simp

* shorten proof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHughes24 ChrisHughes24 ChrisHughes24 approved these changes

@cipher1024 cipher1024 Awaiting requested review from cipher1024

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryangingechen @cipher1024 @ChrisHughes24