Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linear_algebra/dim): findim equivalence #1217

Merged
merged 4 commits into from Jul 22, 2019
Merged

feat(linear_algebra/dim): findim equivalence #1217

merged 4 commits into from Jul 22, 2019

Conversation

abentkamp
Copy link
Collaborator

@abentkamp abentkamp commented Jul 12, 2019 •
edited

Added a lemma stating that every finite dimensional vectorspace over K is isomorphic to K^n.
Some lemmas needed to be generalized in terms of universe levels to achieve that.

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@abentkamp abentkamp requested a review from a team as a code owner July 12, 2019 13:00
@robertylewis
Copy link
Member

This looks great to me. Any objections from others using the linear algebra library? If not, I think it's ready to go.

ChrisHughes24
ChrisHughes24 reviewed Jul 17, 2019
View reviewed changes
src/linear_algebra/finsupp_vector_space.lean Outdated Show resolved Hide resolved
src/linear_algebra/dimension.lean Outdated Show resolved Hide resolved
@ChrisHughes24 ChrisHughes24 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 22, 2019
@mergify mergify bot merged commit a33315d into master Jul 22, 2019
@mergify mergify bot deleted the fin_dim_vectorspace_equiv branch July 22, 2019 19:46
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@abentkamp @anrddh
feat(linear_algebra/dim): findim equivalence (leanprover-community#1217)
afecf3c 
* feat(linear_algebra/dim): findim equivalence

* feat(linear_algebra/dim): two versions of dim_fun

* feat(linear_algebra/dim): clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@ChrisHughes24 ChrisHughes24 ChrisHughes24 approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abentkamp @robertylewis @jcommelin @ChrisHughes24