Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/abelian/homology): Adds API for homology mimicking that of (co)kernels. #12171

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(category_theory/abelian/homology): Adds API for homology mimicking that of (co)kernels. #12171

wants to merge 11 commits into from

Conversation

adamtopaz
Copy link
Collaborator

Open in Gitpod

@adamtopaz adamtopaz added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Feb 20, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 20, 2022
@riccardobrasca
Copy link
Member

Is it possible to add some compatibility with homology.map?

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 21, 2022
@adamtopaz
Copy link
Collaborator Author

Is it possible to add some compatibility with homology.map?

I added a few lemmas: Take your choice: map_eq_left, map_eq_left', map_eq_right or map_eq_right'.

@adamtopaz adamtopaz added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 21, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 21, 2022
erdOne
erdOne reviewed Feb 25, 2022
View reviewed changes
src/category_theory/abelian/homology.lean Outdated Show resolved Hide resolved
src/category_theory/abelian/homology.lean Outdated Show resolved Hide resolved
src/category_theory/abelian/homology.lean Outdated Show resolved Hide resolved
src/category_theory/abelian/homology.lean Show resolved Hide resolved
semorrison
semorrison reviewed Feb 27, 2022
View reviewed changes
src/category_theory/abelian/homology.lean Outdated
exact equalizer.hom_ext h,
end

-- Should this be tagged with `simp`?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@semorrison
Copy link
Collaborator

LGTM. bors d+

@adamtopaz
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 1, 2022
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Mar 1, 2022
bors bot pushed a commit that referenced this pull request Mar 1, 2022
@adamtopaz
feat(category_theory/abelian/homology): Adds API for homology mimicki…
5e36e12 
…ng that of (co)kernels. (#12171)
@bors
Copy link

bors bot commented Mar 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/abelian/homology): Adds API for homology mimicking that of (co)kernels. [Merged by Bors] - feat(category_theory/abelian/homology): Adds API for homology mimicking that of (co)kernels. Mar 1, 2022
@bors bors bot closed this Mar 1, 2022
@bors bors bot deleted the homology_cokernel_kernel branch March 1, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@jcommelin jcommelin jcommelin left review comments

@erdOne erdOne erdOne left review comments

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamtopaz @riccardobrasca @semorrison @jcommelin @erdOne