Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(order/{complete_lattice,sup_indep}): move complete_lattice.independent #12588

Closed

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 11, 2022

Putting this here means that in future we can talk about pairwise_disjoint at the same time, which was previously defined downstream of complete_lattice.independent.
This commit only moves existing declarations and adjusts module docstrings.

The new authorship comes from #5971 and #7199, which predate this file.


Open in Gitpod

This makes `complete_lattice.independent` easier to work with in the degenerate case.
…ependent` to be beside `finset.sup_indep`

Putting this here means that in future we can talk about `pairwise_disjoint` at the same time, which was previously defined downstream of `complete_lattice.independent`.
This commit only moves existing declarations and adjusts module docstrings.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 12, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 13, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

src/order/sup_indep.lean Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request Mar 21, 2022
…ependent` (#12588)

Putting this here means that in future we can talk about `pairwise_disjoint` at the same time, which was previously defined downstream of `complete_lattice.independent`.
This commit only moves existing declarations and adjusts module docstrings.

The new authorship comes from #5971 and #7199, which predate this file.
@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 21, 2022
@bors
Copy link

bors bot commented Mar 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/{complete_lattice,sup_indep}): move complete_lattice.independent [Merged by Bors] - chore(order/{complete_lattice,sup_indep}): move complete_lattice.independent Mar 21, 2022
@bors bors bot closed this Mar 21, 2022
@bors bors bot deleted the eric-wieser/move-complete_lattice.independent branch March 21, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants