-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(order/sup_indep): lemmas about pairwise
and set.pairwise
#12590
Closed
eric-wieser
wants to merge
8
commits into
master
from
eric-wieser/complete_lattice.independent.pairwise
Closed
[Merged by Bors] - feat(order/sup_indep): lemmas about pairwise
and set.pairwise
#12590
eric-wieser
wants to merge
8
commits into
master
from
eric-wieser/complete_lattice.independent.pairwise
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
The author would like community review of the PR
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
labels
Mar 11, 2022
leanprover-community-bot-assistant
added
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Mar 12, 2022
leanprover-community-bot-assistant
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Mar 21, 2022
This PR/issue depends on: |
leanprover-community-bot-assistant
removed
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Mar 21, 2022
eric-wieser
force-pushed
the
eric-wieser/complete_lattice.independent.pairwise
branch
from
March 21, 2022 18:01
5137e1e
to
fd09382
Compare
eric-wieser
changed the title
feat(order/sup_indep): change lemmas to use pairwise and
feat(order/sup_indep): lemmas about Mar 21, 2022
set.pairwise
pairwise
and set.pairwise
YaelDillies
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 30, 2022
bors bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
…2590) The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions. This wasn't previously possible as these definitions were not yet imported. This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
Build failed: |
…e_lattice.independent.pairwise
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
…2590) The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions. This wasn't previously possible as these definitions were not yet imported. This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(order/sup_indep): lemmas about
[Merged by Bors] - feat(order/sup_indep): lemmas about Mar 31, 2022
pairwise
and set.pairwise
pairwise
and set.pairwise
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
…2590) The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions. This wasn't previously possible as these definitions were not yet imported. This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
…2590) The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions. This wasn't previously possible as these definitions were not yet imported. This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
…2590) The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions. This wasn't previously possible as these definitions were not yet imported. This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
disjoint
lemmas can now be stated in terms of these twopairwise
definitions.This wasn't previously possible as these definitions were not yet imported.
This also adds the
iff
versions of these lemmas, and a docstring tying them all together.complete_lattice.independent
#12588