Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/sup_indep): lemmas about pairwise and set.pairwise #12590

Closed

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 11, 2022

The disjoint lemmas can now be stated in terms of these two pairwise definitions.
This wasn't previously possible as these definitions were not yet imported.

This also adds the iff versions of these lemmas, and a docstring tying them all together.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 21, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 21, 2022
@eric-wieser eric-wieser force-pushed the eric-wieser/complete_lattice.independent.pairwise branch from 5137e1e to fd09382 Compare March 21, 2022 18:01
@eric-wieser eric-wieser changed the title feat(order/sup_indep): change lemmas to use pairwise and set.pairwise feat(order/sup_indep): lemmas about pairwise and set.pairwise Mar 21, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/order/sup_indep.lean Outdated Show resolved Hide resolved
src/order/sup_indep.lean Outdated Show resolved Hide resolved
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@ocfnash
Copy link
Collaborator

ocfnash commented Mar 30, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 30, 2022
bors bot pushed a commit that referenced this pull request Mar 30, 2022
…2590)

The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions.
This wasn't previously possible as these definitions were not yet imported.

This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
@bors
Copy link

bors bot commented Mar 30, 2022

Build failed:

@eric-wieser
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 31, 2022
…2590)

The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions.
This wasn't previously possible as these definitions were not yet imported.

This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
@bors
Copy link

bors bot commented Mar 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/sup_indep): lemmas about pairwise and set.pairwise [Merged by Bors] - feat(order/sup_indep): lemmas about pairwise and set.pairwise Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
@bors bors bot deleted the eric-wieser/complete_lattice.independent.pairwise branch March 31, 2022 10:35
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
…2590)

The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions.
This wasn't previously possible as these definitions were not yet imported.

This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
…2590)

The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions.
This wasn't previously possible as these definitions were not yet imported.

This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
…2590)

The `disjoint` lemmas can now be stated in terms of these two `pairwise` definitions.
This wasn't previously possible as these definitions were not yet imported.

This also adds the `iff` versions of these lemmas, and a docstring tying them all together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants