[Merged by Bors] - feat(set_theory/ordinal_arithmetic): Coefficients of Cantor Normal Form #12681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
the
awaiting-review
leanprover-community-bot-assistant
added
blocked-by-other-PR
|
This PR/issue depends on: |
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
fpvandoorn
reviewed
Mar 28, 2022
fpvandoorn
added
awaiting-author
2 tasks
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
vihdzp
added
awaiting-review
fpvandoorn
reviewed
Mar 31, 2022
| @@ -2019,7 +2019,7 @@ by rw [CNF_rec, dif_neg o0] | |||
| base-`b` expansion of `o`. | |||
|
|
|||
| `CNF b (b ^ u₁ * v₁ + b ^ u₂ * v₂) = [(u₁, v₁), (u₂, v₂)]` -/ | |||
| def CNF (b := omega) (o : ordinal) : list (ordinal × ordinal) := | |||
| def CNF (b o : ordinal) : list (ordinal × ordinal) := | |||
There was a problem hiding this comment.
If you require that b and o have the same universe level in almost every property about CNF, shouldn't you just require it in the definition of CNF?
There was a problem hiding this comment.
It is required in the definition. But writing p ∈ ordinal × ordinal seems to confuse the kernel, and it ends with all of my lemmas having everything in universe max ?1 ?2 instead of using a single universe. This is why I need the universe annotations.
There was a problem hiding this comment.
Oh I see. Yeah, that sometimes happens. Thanks for the clarification!
fpvandoorn
added
awaiting-author
|
Other than that point, this LGTM. bors d+ |
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
…rm (#12681) We prove all coefficients of the base-b expansion of an ordinal are less than `b`. We also tweak the parameters of various other theorems.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
…rm (#12681) We prove all coefficients of the base-b expansion of an ordinal are less than `b`. We also tweak the parameters of various other theorems.
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
…rm (#12681) We prove all coefficients of the base-b expansion of an ordinal are less than `b`. We also tweak the parameters of various other theorems.
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
…rm (#12681) We prove all coefficients of the base-b expansion of an ordinal are less than `b`. We also tweak the parameters of various other theorems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prove all coefficients of the base-b expansion of an ordinal are less than
b. We also tweak the parameters of various other theorems.CNF_rec#12680