Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(set_theory/ordinal/arithmetic): Rename theorems to match nat.log API #12733

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - refactor(set_theory/ordinal/arithmetic): Rename theorems to match nat.log API #12733

wants to merge 10 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 16, 2022 •
edited

@vihdzp vihdzp added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 16, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 16, 2022
fpvandoorn
fpvandoorn reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some parts of the API where I don't see a clear improvements of the nat.log API over the ordinal.log API. But it's nice to have the same API in both cases.
Maybe you can change the name to log_mono_right in both cases, and rename log_le_log_of_left_ge to log_mono_left?

src/data/nat/log.lean Outdated Show resolved Hide resolved
src/set_theory/ordinal_arithmetic.lean Outdated Show resolved Hide resolved
@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 28, 2022
@fpvandoorn fpvandoorn mentioned this pull request Mar 28, 2022
Closed
1 task
@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 28, 2022
@YaelDillies YaelDillies changed the title refactor(data/nat/log, set_theory/ordinal_arithmetic): Match log API refactor(data/nat/log, set_theory/ordinal/arithmetic): Match log API Apr 21, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 7, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented May 8, 2022

I'll split the data/nat/log part of this PR off, and focus this PR on ordinal.log.

@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 8, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 8, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@vihdzp vihdzp changed the title refactor(data/nat/log, set_theory/ordinal/arithmetic): Match log API refactor(data/nat/log, set_theory/ordinal/arithmetic): Rename theorems to match nat.log API May 8, 2022
@vihdzp vihdzp changed the title refactor(data/nat/log, set_theory/ordinal/arithmetic): Rename theorems to match nat.log API refactor(set_theory/ordinal/arithmetic): Rename theorems to match nat.log API May 8, 2022
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 9, 2022
bors bot pushed a commit that referenced this pull request May 9, 2022
@vihdzp
refactor(set_theory/ordinal/arithmetic): Rename theorems to match `na…
4eb76a7 
…t.log` API (#12733)

We match the API for `ordinal.log` with that of `nat.log`.
@bors
Copy link

bors bot commented May 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(set_theory/ordinal/arithmetic): Rename theorems to match nat.log API [Merged by Bors] - refactor(set_theory/ordinal/arithmetic): Rename theorems to match nat.log API May 9, 2022
@bors bors bot closed this May 9, 2022
@bors bors bot deleted the nat_log branch May 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vihdzp @mathlib-dependent-issues-bot @fpvandoorn @leanprover-community-bot-assistant