Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tactic/symmetry_at): apply symmetry on assumptions #1269

Merged
merged 3 commits into from Jul 31, 2019
Merged

feat(tactic/symmetry_at): apply symmetry on assumptions #1269

merged 3 commits into from Jul 31, 2019

Conversation

cipher1024
Copy link
Collaborator

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@cipher1024 cipher1024 requested a review from a team as a code owner July 26, 2019 20:16
@robertylewis
Copy link
Member

Could you add doc strings for the defs in tactic.core?

@robertylewis robertylewis added the needs-documentation This PR is missing required documentation label Jul 29, 2019
@robertylewis robertylewis added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed needs-documentation This PR is missing required documentation labels Jul 31, 2019
@mergify mergify bot merged commit da46b32 into master Jul 31, 2019
@mergify mergify bot deleted the symmetry-at branch July 31, 2019 10:47
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@cipher1024 @anrddh
feat(tactic/symmetry_at): apply symmetry on assumptions (leanprover-c…
e453ae8 
…ommunity#1269)

* feat(tactic/symmetry_at): apply symmetry on assumptions

* add docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertylewis robertylewis robertylewis approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cipher1024 @robertylewis