doc(data/padics, data/real/cau_seq, algebra): add doc strings, remove unnecessary assumptions #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertylewis
changed the title
robertylewis
changed the title
jcommelin
reviewed
Jul 30, 2019
|
It's a general "cleanup" PR, I figured I might as well do it all together. (This is it, no more coming.) |
|
Ok, I see. Well, I guess we can merge it as soon as Travis confirms that you didn't clean up too much. |
|
Okay, this version definitely builds (and fixes a cascade of unnecessary arguments). |
sgouezel
reviewed
Jul 30, 2019
sgouezel
reviewed
Jul 30, 2019
sgouezel
reviewed
Jul 30, 2019
sgouezel
reviewed
Jul 30, 2019
sgouezel
reviewed
Jul 30, 2019
|
Thanks @sgouezel , good catch! Updated. |
sgouezel
added
the
ready-to-merge
sgouezel
approved these changes
Jul 31, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
… unnecessary assumptions (leanprover-community#1283) * doc(data/padics): add doc strings, remove unnecessary prime assumptions * fix(data/real/cau_seq): remove unnecessary hypotheses * fix(algebra/{field, ordered_field}): remove unused assumptions * doc(data/real/cau_seq): document Cauchy sequences * fix(algebra/field): remove obsolete lemma * fix build * fix build * more unnecessary arguments * Update src/data/padics/padic_numbers.lean * Update src/data/padics/padic_numbers.lean * remove another unnecessary argument (suggested by @sgouezel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few declarations from #1282 (as well as one that didn't show up on that list for some reason), and adds documentation as per #1260 .
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list