feat(tactic/obtain): make type argument optional #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
cipher1024
approved these changes
Aug 17, 2019
robertylewis
added
the
ready-to-merge
cipher1024
pushed a commit
that referenced
this pull request
Aug 23, 2019
* feat(tactic/obtain): make type argument optional * fix(tactic/obtain): unnecessary steps * feat(tactic/obtain): simplify cases
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…y#1327) * feat(tactic/obtain): make type argument optional * fix(tactic/obtain): unnecessary steps * feat(tactic/obtain): simplify cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/obtain/near/173183243
obtain ⟨h, h2⟩ := and.intro trivial trivialis equivalent torcases and.intro trivial trivial with ⟨h, h2⟩, but I think there's no reason not to support it withobtainas well.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list