This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(number_theory/quadratic_reciprocity): change order of arguments … #13311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelStollBayreuth
added
the
awaiting-review
jcommelin
reviewed
Apr 11, 2022
| @@ -356,13 +360,13 @@ namespace zmod | |||
| * `-1` otherwise. | |||
|
|
|||
| -/ | |||
| def legendre_sym (a : ℤ) (p : ℕ) : ℤ := | |||
| def legendre_sym (p : ℕ) (a : ℤ) : ℤ := | |||
There was a problem hiding this comment.
Please also include a warning about the order of the arguments in the docstring. (I saw you already added that warning above in the module docs.)
There was a problem hiding this comment.
Thanks; I had overlooked that. I have changed the docstring accordingly.
jcommelin
added
awaiting-author
MichaelStollBayreuth
added
awaiting-review
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2022
#13311) …in legendre_sym This is the first step in a major overhaul of the contents of number_theory/quadratic_reciprocity. As a first step, the order of the arguments `a` and `p` to `legendre_sym` is swapped, based on a [poll](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Quadratic.20Hilbert.20symbol.20over.20.E2.84.9A) on Zulip.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in legendre_sym
This is the first step in a major overhaul of the contents of number_theory/quadratic_reciprocity.
As a first step, the order of the arguments
aandptolegendre_symis swapped, based on a poll on Zulip.