Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(group_theory/exponent): generalise #13647

Closed
wants to merge 1 commit into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Apr 23, 2022

Generalises a few lemmas to not require cancellativity.


Open in Gitpod

This was found by the generalisation linter, and was a huge surprise to me as I remember these needing the cancellation requirement! (I wrote these proofs)

@ericrbg ericrbg added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Apr 23, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 23, 2022
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 23, 2022
bors bot pushed a commit that referenced this pull request Apr 23, 2022
Generalises a few lemmas to not require cancellativity.
@bors
Copy link

bors bot commented Apr 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/exponent): generalise [Merged by Bors] - chore(group_theory/exponent): generalise Apr 24, 2022
@bors bors bot closed this Apr 24, 2022
@bors bors bot deleted the ericrbg/generalise-monoid branch April 24, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants