Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/submonoid/membership): generalize a few lemmas to mul_mem_class #13748

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(ring_theory/submonoid/membership): generalize a few lemmas to mul_mem_class #13748

wants to merge 3 commits into from

Conversation

j-loreaux
Copy link
Collaborator

This generalizes lemmas relating to the additive closure of a multiplicative monoid so that they also apply to multiplicative semigroups using mul_mem_class

Open in Gitpod

@j-loreaux j-loreaux added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 27, 2022
@j-loreaux j-loreaux mentioned this pull request Apr 27, 2022
Closed
5 tasks
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 27, 2022
eric-wieser
eric-wieser approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors bot pushed a commit that referenced this pull request Apr 28, 2022
@j-loreaux
feat(ring_theory/submonoid/membership): generalize a few lemmas to `m…
0d3f8a7 
…ul_mem_class` (#13748)

This generalizes lemmas relating to the additive closure of a multiplicative monoid so that they also apply to multiplicative semigroups using `mul_mem_class`
@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 28, 2022
@bors
Copy link

bors bot commented Apr 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/submonoid/membership): generalize a few lemmas to mul_mem_class [Merged by Bors] - feat(ring_theory/submonoid/membership): generalize a few lemmas to mul_mem_class Apr 28, 2022
@bors bors bot closed this Apr 28, 2022
@bors bors bot deleted the j-loreaux/mul-mem-add-closure branch April 28, 2022 19:14
bors bot pushed a commit that referenced this pull request Nov 11, 2022
@j-loreaux
feat(ring_theory/non_unital_subsemiring/basic): introduce non-unital …
3711afe 
…subsemirings and develop basic API (#13749)

- [x] depends on: #13627 
- [x] depends on: #13747 
- [x] depends on: #13748
- [x] depends on: #13945 
- [x] depends on: #13958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-loreaux @eric-wieser @leanprover-community-bot-assistant