Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/non_unital_subsemiring/basic): introduce non-unital subsemirings and develop basic API #13749

Closed
wants to merge 61 commits into from

Conversation

@j-loreaux j-loreaux added the WIP Work in progress label Apr 27, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 27, 2022
@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 21, 2022
@j-loreaux
Copy link
Collaborator Author

@eric-wieser: I requested your review specifically because I wrote all this up a few months ago and I noticed you had changed things recently with srestrict to take advantage of the new subobject type classes. I think I handled that correctly, but let me know if not.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 22, 2022
@riccardobrasca
Copy link
Member

LGTM. I think we can merge it and then maybe change something later if we have to.

@j-loreaux
Copy link
Collaborator Author

@eric-wieser, what do you think?

@j-loreaux j-loreaux added the t-algebra Algebra (groups, rings, fields etc) label Oct 14, 2022
@eric-wieser eric-wieser removed their assignment Nov 9, 2022
@ocfnash ocfnash self-assigned this Nov 10, 2022
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I hope one day that we can delegate such code to the computer.

I left a few optional comments which I encourage you to consider but this is all OK as it stands.

bors d+

@bors
Copy link

bors bot commented Nov 10, 2022

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 10, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Nov 10, 2022

Just in case: please merge master into this branch before sending it to bors.

@j-loreaux
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Nov 11, 2022
…subsemirings and develop basic API (#13749)

- [x] depends on: #13627 
- [x] depends on: #13747 
- [x] depends on: #13748
- [x] depends on: #13945 
- [x] depends on: #13958
@bors
Copy link

bors bot commented Nov 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/non_unital_subsemiring/basic): introduce non-unital subsemirings and develop basic API [Merged by Bors] - feat(ring_theory/non_unital_subsemiring/basic): introduce non-unital subsemirings and develop basic API Nov 11, 2022
@bors bors bot closed this Nov 11, 2022
@bors bors bot deleted the j-loreaux/non-unital-subring branch November 11, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants