-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ring_theory/non_unital_subsemiring/basic): introduce non-unital subsemirings and develop basic API #13749
Conversation
@eric-wieser: I requested your review specifically because I wrote all this up a few months ago and I noticed you had changed things recently with |
LGTM. I think we can merge it and then maybe change something later if we have to. |
@eric-wieser, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I hope one day that we can delegate such code to the computer.
I left a few optional comments which I encourage you to consider but this is all OK as it stands.
bors d+
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
Just in case: please merge master into this branch before sending it to bors. |
bors merge |
Pull request successfully merged into master. Build succeeded: |
mul_one_class
tohas_mul
#13747mul_mem_class
#13748