New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(analysis/analytic_composition): weaken some typeclass arguments #13924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
The author would like community review of the PR
label
May 3, 2022
eric-wieser
changed the title
chore(analysis/*): generalize some typeclasses
chore(analysis/*): weaken some typeclass arguments
May 3, 2022
eric-wieser
changed the title
chore(analysis/*): weaken some typeclass arguments
chore(analysis/analytic_composition): weaken some typeclass arguments
May 3, 2022
eric-wieser
force-pushed
the
eric-wieser/more-normed_space
branch
from
May 3, 2022 23:52
fc9481e
to
47c16a0
Compare
eric-wieser
force-pushed
the
eric-wieser/more-normed_space
branch
from
May 3, 2022 23:53
47c16a0
to
16a221f
Compare
semorrison
added
awaiting-author
A reviewer has asked the author a question or requested changes
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
May 4, 2022
eric-wieser
removed
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
May 4, 2022
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
May 4, 2022
bors r+ |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
May 4, 2022
bors bot
pushed a commit
that referenced
this pull request
May 4, 2022
…#13924) There's no need to do a long computation to show the multilinear_map is bounded, when continuity follows directly from the definition. This deletes `comp_along_composition_aux`, and moves the lemmas about the norm of `comp_along_composition` further down the file so as to get the lemmas with weaker typeclass requirements out of the way first. The norm proofs are essentially unchanged.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 4, 2022
…#13924) There's no need to do a long computation to show the multilinear_map is bounded, when continuity follows directly from the definition. This deletes `comp_along_composition_aux`, and moves the lemmas about the norm of `comp_along_composition` further down the file so as to get the lemmas with weaker typeclass requirements out of the way first. The norm proofs are essentially unchanged.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
chore(analysis/analytic_composition): weaken some typeclass arguments
[Merged by Bors] - chore(analysis/analytic_composition): weaken some typeclass arguments
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to do a long computation to show the multilinear_map is bounded, when continuity follows directly from the definition.
This deletes
comp_along_composition_aux
, and moves the lemmas about the norm ofcomp_along_composition
further down the file so as to get the lemmas with weaker typeclass requirements out of the way first.The norm proofs are essentially unchanged.