Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/analytic_composition): weaken some typeclass arguments #13924

Closed
wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 3, 2022

There's no need to do a long computation to show the multilinear_map is bounded, when continuity follows directly from the definition.

This deletes comp_along_composition_aux, and moves the lemmas about the norm of comp_along_composition further down the file so as to get the lemmas with weaker typeclass requirements out of the way first.
The norm proofs are essentially unchanged.


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label May 3, 2022
@eric-wieser eric-wieser changed the title chore(analysis/*): generalize some typeclasses chore(analysis/*): weaken some typeclass arguments May 3, 2022
@eric-wieser eric-wieser changed the title chore(analysis/*): weaken some typeclass arguments chore(analysis/analytic_composition): weaken some typeclass arguments May 3, 2022
@eric-wieser eric-wieser force-pushed the eric-wieser/more-normed_space branch from fc9481e to 47c16a0 Compare May 3, 2022 23:52
@eric-wieser eric-wieser force-pushed the eric-wieser/more-normed_space branch from 47c16a0 to 16a221f Compare May 3, 2022 23:53
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI The author would like to see what CI has to say before doing more work. labels May 4, 2022
@eric-wieser eric-wieser removed the awaiting-author A reviewer has asked the author a question or requested changes label May 4, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 4, 2022
@jcommelin jcommelin requested a review from sgouezel May 4, 2022 10:15
@sgouezel
Copy link
Collaborator

sgouezel commented May 4, 2022

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 4, 2022
bors bot pushed a commit that referenced this pull request May 4, 2022
…#13924)

There's no need to do a long computation to show the multilinear_map is bounded, when continuity follows directly from the definition.

This deletes `comp_along_composition_aux`, and moves the lemmas about the norm of `comp_along_composition` further down the file so as to get the lemmas with weaker typeclass requirements out of the way first.
The norm proofs are essentially unchanged.
@bors
Copy link

bors bot commented May 4, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 4, 2022
…#13924)

There's no need to do a long computation to show the multilinear_map is bounded, when continuity follows directly from the definition.

This deletes `comp_along_composition_aux`, and moves the lemmas about the norm of `comp_along_composition` further down the file so as to get the lemmas with weaker typeclass requirements out of the way first.
The norm proofs are essentially unchanged.
@bors
Copy link

bors bot commented May 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/analytic_composition): weaken some typeclass arguments [Merged by Bors] - chore(analysis/analytic_composition): weaken some typeclass arguments May 4, 2022
@bors bors bot closed this May 4, 2022
@bors bors bot deleted the eric-wieser/more-normed_space branch May 4, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants