feat(logic/basic): exists_eq' #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a great name, but `exists_eq_left` and `exists_eq_right` are taken, and it's unlikely to be used except in `simp`
cipher1024
added
the
ready-to-merge
cipher1024
approved these changes
Sep 4, 2019
jcommelin
reviewed
Sep 4, 2019
| @@ -477,6 +477,8 @@ by simp [and_comm] | |||
|
|
|||
| @[simp] theorem exists_eq {a' : α} : ∃ a, a = a' := ⟨_, rfl⟩ | |||
|
|
|||
| @[simp] theorem exists_eq' {a' : α} : Exists (eq a') := ⟨_, rfl⟩ | |||
There was a problem hiding this comment.
Suggested change
| @[simp] theorem exists_eq' {a' : α} : Exists (eq a') := ⟨_, rfl⟩ | |
| @[simp] theorem Exists_eq {a' : α} : Exists (eq a') := ⟨_, rfl⟩ |
How about this name?
There was a problem hiding this comment.
It doesn't seem to be the convention. Exists should really be called exists
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
Not a great name, but `exists_eq_left` and `exists_eq_right` are taken, and it's unlikely to be used except in `simp`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a great name, but
exists_eq_leftandexists_eq_rightare taken, and it's unlikely to be used except insimpTO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list