Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/{pgame, basic}): Notation for relabelling, golfing #14155

Closed
wants to merge 11 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented May 15, 2022

We introduce the notation ≡r for relabellings between two pre-games. We also golf many theorems on relabellings.


I intend to use for identical pre-games (i.e. extensionally equal) at a later point.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label May 15, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 20, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@vihdzp
Copy link
Collaborator Author

vihdzp commented Jun 4, 2022

In the long run, we should phase out some of the equiv lemmas in favor of their relabelling counterparts. It's an analogous situation to having le lemmas alongside their lt counterparts (as in, we shouldn't do it unless in very special cases). But that can wait for another PR.

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Jun 15, 2022
@robertylewis
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jun 15, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jun 15, 2022
@vihdzp vihdzp added awaiting-CI The author would like to see what CI has to say before doing more work. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Jun 15, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 15, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Jun 16, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 16, 2022
…14155)

We introduce the notation `≡r` for relabellings between two pre-games. We also golf many theorems on relabellings.
@bors
Copy link

bors bot commented Jun 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/{pgame, basic}): Notation for relabelling, golfing [Merged by Bors] - feat(set_theory/{pgame, basic}): Notation for relabelling, golfing Jun 16, 2022
@bors bors bot closed this Jun 16, 2022
@bors bors bot deleted the identical_v2 branch June 16, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants