This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - refactor(set_theory/game/nim): 0 ≈ nim 0
→ nim 0 ≈ 0
#14270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
easy
< 20s of review time. See the lifecycle page for guidelines.
awaiting-review
The author would like community review of the PR
labels
May 20, 2022
This was referenced May 20, 2022
eric-wieser
reviewed
May 20, 2022
eric-wieser
reviewed
May 21, 2022
eric-wieser
reviewed
May 21, 2022
end | ||
|
||
@[simp] theorem nim_one_equiv : star ≈ nim 1 := nim_one_relabelling.equiv | ||
@[simp] theorem star_equiv_nim : star ≈ nim 1 := star_relabelling_nim.equiv | ||
|
||
@[simp] lemma nim_birthday (O : ordinal) : (nim O).birthday = O := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that if we flip the above we should ensure we have a simp lemma that says star.birthday = 1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't currently have said lemma, but I believe it would rather belong as a basic lemma on birthday.lean
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kim-em
removed
the
easy
< 20s of review time. See the lifecycle page for guidelines.
label
May 22, 2022
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
May 22, 2022
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
refactor(set_theory/game/nim):
[Merged by Bors] - refactor(set_theory/game/nim): May 23, 2022
0 ≈ nim 0
→ nim 0 ≈ 0
0 ≈ nim 0
→ nim 0 ≈ 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We invert the directions of a few simple equivalences/relabellings to a more natural order (simpler on the RHS).