This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(ring_theory/ideal/operations.lean): lemmas about coprime ideals #14176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pbazin
added
the
awaiting-review
The author would like community review of the PR
label
May 16, 2022
riccardobrasca
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it is possible to extract some sublemmas from the proof?
The proofs of both directions of the iff could be separated in two lemmas but otherwise not |
Thanks! bors d+ |
✌️ pbazin can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
May 18, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2022
…14176) Generalises some lemmas from `ring_theory/coprime/lemmas.lean` to the case of non-principal ideals.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(ring_theory/ideal/operations.lean): lemmas about coprime ideals
[Merged by Bors] - feat(ring_theory/ideal/operations.lean): lemmas about coprime ideals
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalises some lemmas from
ring_theory/coprime/lemmas.lean
to the case of non-principal ideals.